Fixed NPE for unknown request in FilterChainProxy #18166
+19
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
Closes spring-projects#18157 Signed-off-by: Soumik Sarker <ronodhirsoumik@gmail.com>
ronodhirSoumik
force-pushed
the
bugfix/fixed-npe-in-FilterChainProxy
branch
from
539fa3e to
c8bd4d4
Compare
Comment on lines
+338
to
+339
| String requestMethod = request.getMethod(); | ||
| return requestMethod != null && this.method.name().equals(requestMethod); |
Contributor
There was a problem hiding this comment.
We don’t need to check for null because this.method.name() will return a String type and String#equals(null) will return false, so the test passes without any changes.
Contributor
Author
There was a problem hiding this comment.
but this fixes the NPE case - ig that is our expectation of getting false for invalid
Contributor
There was a problem hiding this comment.
this.method.name().equals(request.getMethod()) will return false if request.getMethod() == null and won’t throw an NPE unless request is null or method is null. The test passes without any changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18157